[Mesa-stable] [Mesa-dev] [PATCH] st/mesa: force depth mode to GL_RED for sized depth/stencil formats

[Ilia Mirkin]

On Wed, Feb 17, 2016 at 3:26 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On Wednesday, February 17, 2016 8:21:32 AM PST Ilia Mirkin wrote:
>> See commit 9db2098d for the i965 version of this.
>>
>> This fixes depth in a bunch of dEQP EXT_texture_border_clamp tests. And
>> probably other ones as well.
>>
>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>> Cc: Ian Romanick <idr at freedesktop.org>
>> Cc: mesa-stable at lists.freedesktop.org
>> ---
>>
>> This replaces my patch "mesa: default DepthMode to GL_RED on ES 3.0" which
>> tried to do it at the global level. Unfortunately this needs to only apply
>> to sized format, so it can't be done until the texture is complete.
>>
>>  src/mesa/state_tracker/st_atom_texture.c | 34 ++++++++++++++++++++++
> +---------
>>  1 file changed, 25 insertions(+), 9 deletions(-)
>
> This looks good to me.  For what it's worth,
>
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Thanks. There not having been other comments on this patch, I'm going
to push this later today. A later change can try to clean this up so
that the driver doesn't have to care about this annoyance by reverting
both this and the i965-specific handling... I think Ian had some
ideas, but it all seems very sadly intertwined.

  -ilia