[Mesa-stable] [Mesa-dev] [PATCH 1/2] winsys/svga: Fix an uninitialized return value

Brian Paul brianp at vmware.com
Thu Feb 25 15:10:02 UTC 2016


On 02/25/2016 03:02 AM, Thomas Hellstrom wrote:
> Reported-by: Brian Paul <brianp at vmware.com>
> Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
> Reviwed-by: Brian Paul <brianp at vmware.com>

"Reviewed"

> Cc: "11.0 11.1" <mesa-stable at lists.freedesktop.org>
> ---
>   src/gallium/winsys/svga/drm/vmw_surface.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/src/gallium/winsys/svga/drm/vmw_surface.c b/src/gallium/winsys/svga/drm/vmw_surface.c
> index 6c0ad3b..a438b1a 100644
> --- a/src/gallium/winsys/svga/drm/vmw_surface.c
> +++ b/src/gallium/winsys/svga/drm/vmw_surface.c
> @@ -170,6 +170,8 @@ vmw_svga_winsys_surface_unmap(struct svga_winsys_context *swc,
>         *rebind = vsrf->rebind;
>         vsrf->rebind = FALSE;
>         vmw_svga_winsys_buffer_unmap(&vsrf->screen->base, vsrf->buf);
> +   } else {
> +      *rebind = FALSE;
>      }
>      pipe_mutex_unlock(vsrf->mutex);
>   }
>

Both LGTM, again.

-Brian



More information about the mesa-stable mailing list