[Mesa-stable] [Mesa-dev] [PATCH 01/13] vbo: Declare the index range invalid for DrawIndirect

[Michael Schellenberger Costa]

Hi Jason,

Am 19.05.2016 um 09:20 schrieb Jason Ekstrand:
> Right now, we're just setting the range to [0, MAX_UINT32] which, while
> correct isn't helpful.  With DrawIndirect, you can't really know what the
> actual range is so we may as well flag it as being an invalid range.  This
> is what we do for draws with index buffer which is similar (the indices
> aren't statically known) if a bit simpler.
> 
> Cc: "10.2" <mesa-stable at lists.freedesktop.org>
> ---
>  src/mesa/vbo/vbo_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c
> index 9f807a1..ae5d265 100644
> --- a/src/mesa/vbo/vbo_context.c
> +++ b/src/mesa/vbo/vbo_context.c
> @@ -170,7 +170,7 @@ vbo_draw_indirect_prims(struct gl_context *ctx,
>     }
>  
>     vbo->draw_prims(ctx, prim, draw_count,
> -                   ib, GL_TRUE, 0, ~0,
> +                   ib, false, ~0, ~0,
Out of curiosity. The former was GL_TRUE so shouldn't you use GL_FALSE
here or do you plan to migrate that? If you do you might want to sed
them for that file?
--Michael
>                     NULL, 0,
>                     ctx->DrawIndirectBuffer);
>  
>