[Mesa-stable] [V2 PATCH] meta: Fix the pbo usage in meta for GLES{1, 2} contexts

Anuj Phogat anuj.phogat at gmail.com
Thu May 26 17:37:02 UTC 2016


On Thu, May 26, 2016 at 7:18 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Hi all,
>
> On 2 March 2016 at 03:22, Ian Romanick <idr at freedesktop.org> wrote:
>> Sorry for the delay.
>>
>> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>>
>>
>> On 02/09/2016 03:28 PM, Anuj Phogat wrote:
>>> OpenGL ES 1.0 doesn't support using GL_STREAM_DRAW and both
>>> ES 1.0 and 2.0 don't support GL_STREAM_READ in glBufferData().
>>> So, handle it correctly by calling the _mesa_meta_begin()
>>> before create_texture_for_pbo().
>>>
>>> V2: Remove the changes related to allocate_storage. (Ian)
>>>
>>> Cc: Ian Romanick <idr at freedesktop.org>
>>> Cc: "11.1" <mesa-stable at lists.freedesktop.org>
>>
>>       "11.1 11.2"
>>
>>> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
>>> ---
>>>  src/mesa/drivers/common/meta_tex_subimage.c | 21 +++++++++++++--------
>>>  1 file changed, 13 insertions(+), 8 deletions(-)
>>>
> It doesn't seem like this patch has landed yet, despite being
> reviewed. Sadly it no longer applies cleanly to master, so I'm
> wondering if it's still applicable or there's an alternative solution
> (be that merged or not).
>
> Thanks
> Emil

This patch has landed in commit 6d4ebbe.


More information about the mesa-stable mailing list