[Mesa-stable] [Mesa-dev] [PATCH 2/2] Make shader refcounting atomic.

Steinar H. Gunderson steinar+mesa at gunderson.no
Sun Nov 6 21:55:20 UTC 2016


On Mon, Nov 07, 2016 at 08:42:18AM +1100, Timothy Arceri wrote:
>> Interesting. So other code seemingly has done refcounting with non-
>> atomics but with locking; those locks were just missing here.
> I was trying to point you to the fact that locking is known to be
> broken in some places in case you happen to hit further problems :)

Yes, I understood -- but evidently, at least some places _had_ gotten the
refcounting right (by locking the mutex before manipulating the count).

Then there's my own https://bugs.freedesktop.org/show_bug.cgi?id=98602,
about races on (seemingly) buffer object state. Come to think of it, I
wonder if this is the same root cause as what makes CasparCG unusable on i965
(https://bugs.freedesktop.org/show_bug.cgi?id=91379).

/* Steinar */
-- 
Homepage: https://www.sesse.net/


More information about the mesa-stable mailing list