[Mesa-stable] [PATCH v2 01/14] egl: return error for unknown EGLImage attributes
Varad Gautam
varadgautam at gmail.com
Thu Nov 24 15:20:38 UTC 2016
From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
Commit 0135e5d6c83add5e539492a4899504e33f3f2434 "egl: Add support for
more EGLImage extensions to EGL core." removed an error code for unknown
EGLImage attributes without explaining why.
EGL_KHR_image_base says:
* If an attribute specified in <attrib_list> is not one of the
attributes listed in Table bbb, the error EGL_BAD_PARAMETER is
generated.
Implement this.
Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
Signed-off-by: Varad Gautam <varad.gautam at collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
CC: <mesa-stable at lists.freedesktop.org>
---
src/egl/main/eglimage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/egl/main/eglimage.c b/src/egl/main/eglimage.c
index 818b597..411d1ca 100644
--- a/src/egl/main/eglimage.c
+++ b/src/egl/main/eglimage.c
@@ -170,7 +170,7 @@ _eglParseImageAttribList(_EGLImageAttribs *attrs, _EGLDisplay *dpy,
break;
default:
- /* unknown attrs are ignored */
+ err = EGL_BAD_PARAMETER;
break;
}
--
2.6.2
More information about the mesa-stable
mailing list