[Mesa-stable] [Mesa-dev] [PATCH] st/mesa: only set primitive_restart when the restart index is in range

Marek Olšák maraeo at gmail.com
Thu Oct 20 09:41:18 UTC 2016


I think st_indirect_draw_vbo needs the same fix.

Marek

On Wed, Oct 19, 2016 at 11:14 PM, Marek Olšák <maraeo at gmail.com> wrote:
> On Wed, Oct 19, 2016 at 8:39 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
>> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
>>
>> Even when enabled, primitive restart has no effect when the restart index
>> is larger than the representable values in the index buffer.
>>
>> Fixes GL45-CTS.gtf31.GL3Tests.primitive_restart.primitive_restart_upconvert
>> for radeonsi.
>
> BTW, this fails on VI, but passes on CIK. The reason is that the hw
> team changed the behavior and now it masks out the unused bits I
> think. VI is and will be the only generation where it's different and
> not configurable.
>
> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>
> Marek


More information about the mesa-stable mailing list