[Mesa-stable] [Mesa-dev] [PATCH 1/2] configure.ac: fold xxd's -i within XXD

Matt Turner mattst88 at gmail.com
Fri Oct 28 18:34:47 UTC 2016


On Fri, Oct 28, 2016 at 11:12 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> Otherwise we get annoying messages like the following when xxd is
> missing.
>
> /bin/sh: line 2: -i: command not found

That error is better than what we'd get after this patch. "cat ... |
>> ..." looks like it generates

zsh: parse error near `\n'

and

bash: syntax error near unexpected token `newline'

>
> Cc: mesa-stable at lists.freedesktop.org
> Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> I'm wondering if we shouldn't give some form or warning/error message
> when xxd is missing ?

Just fix the real problem of checking for xxd. It should be the same
as what we do with bison and flex.


More information about the mesa-stable mailing list