[Mesa-stable] [Mesa-dev] [PATCH] st/va: also honors interlaced preference when providing a video format

[Andy Furniss]

Andy Furniss wrote:
> Leo Liu wrote:
>> Hi Andy,
>>
>> On 09/13/2016 06:22 AM, Andy Furniss wrote:
>>> Zhang, Boyuan wrote:
>>>> Hi Leo, Christian and Julien,
>>>>
>>>> I tested the patch with Vaapi Encoding and Transcoding, it seems
>>>> working fine. We are using "VAAPI_DISABLE_INTERLACE" env, so
>>>> interlaced is always disabled.
>>>
>>> Though I notice it will break screen recording scripts for existing
>>> users who previously didn't need the env set but will after this.
>>>
>>> Totally untested/thought through, but maybe the env should default to
>>> on?
>>
>> Agree, can you come up a patch for that?
>
> OK, but maybe I should test a bit first to see if anything regresses.

It seems true is needed for most gstreamer encodes now, so I guess it 
will need to be set on.

As for regressions I haven't tried ffmpeg encode as it's currently not 
working.

One I found with mpv which I guess is obvious =

mpv --hwdec=vaapi --vo=vaapi foo

works with or without the env, but if foo is interlaced you can't use 
the vavpp de-interlacer with the env set.