[Mesa-stable] [Mesa-dev] [PATCH 2/2] egl/drm: set the VISUAL_TYPE alongside the VISUAL_ID

[Daniel Stone]

Hi,

On 21 August 2017 at 18:30, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 21 August 2017 at 15:44, Daniel Stone <daniel at fooishbar.org> wrote:
>> My take on it is that the visual types are defined by the platform,
>> and 0 is a perfectly sensible visual type for a platform which does
>> not actually have any.
>>
> Having the exact same visual type for all visual IDs does strikes me
> as a bit odd.
> That said, the spec does not explicitly forbids it so I guess it should be fine?

It should be, yeah. It would be quite odd to use anything other than
TrueColor for X11, so in effect that only has one value for the type
either. Maybe just imagine '#define GBM_VISUAL_TYPE_FOURCC 0'
existing, with no others to ever be defined, and then it might make
more sense?

Cheers,
Daniel