[Mesa-stable] [Mesa-dev] [PATCH v2 1/2] gallivm: correct channel shift logic on big endian

Ray Strode halfline at gmail.com
Wed Aug 23 20:44:11 UTC 2017


Hi,

Just a quick note...

> From: Ray Strode <rstrode at redhat.com>
>
> lp_build_fetch_rgba_soa fetches a texel from a texture.
> Part of that process involves first gathering the element
> together from memory into a packed format, and then breaking
> out the individual color channels into separate, parallel
> arrays.
>
> The code fails to account for endianess when reading the packed
> values.
>
> This commit attempts to correct the problem by reversing the order
> the packed values are read on big endian systems.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100613
> Cc: "17.2" "17.1" <mesa-stable at lists.freedesktop.org>
If consensus is this patch is good enough for now, then it's, of course,
got my

Signed-off-by: Ray Strode <rstrode at redhat.com>

--Ray


More information about the mesa-stable mailing list