[Mesa-stable] [PATCH] glx: GLX_MESA_multithread_makecurrent is direct-only

[Ian Romanick]

On 12/06/2017 10:32 AM, Emil Velikov wrote:
> On 5 December 2017 at 16:10, Adam Jackson <ajax at redhat.com> wrote:
>> This extension is not defined for indirect contexts. Marking it as
>> "client only", as the old code did here, would make the extension
>> available in indirect contexts, even though the server would certainly
>> not have it in its extension list.
>>
>> Cc: <mesa-stable at lists.freedesktop.org>
>> Signed-off-by: Adam Jackson <ajax at redhat.com>
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> Unrelated: reportedly only cairo is using the extension, so could we
> consider the extension obsolete?

It's not too surprising that only Cairo is using it.  IIRC, Eric
specifically made this extension for Cairo, and it was a pretty big perf
win at the time.

I had wanted to test this patch, but... does LIBGL_ALWAYS_INDIRECT=y
just not work any more?  With the distro Mesa I get:

name of display: :0
X Error of failed request:  GLXBadContext
  Major opcode of failed request:  151 (GLX)
  Minor opcode of failed request:  6 (X_GLXIsDirect)
  Serial number of failed request:  37
  Current serial number in output stream:  36

And with fairly recent master I get direct rendering.

> Alternatively how about making it an official Khronos extension ;-)
> 
> -Emil
> _______________________________________________
> mesa-stable mailing list
> mesa-stable at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-stable