[Mesa-stable] [Mesa-dev] [PATCH 1/2] i965/bufmgr: Add a helper to mark a BO as external

[Emil Velikov]

On 11 December 2017 at 22:03, Jason Ekstrand <jason at jlekstrand.net> wrote:
> On Mon, Dec 11, 2017 at 12:08 PM, Emil Velikov <emil.l.velikov at gmail.com>
> wrote:
>>
>> On 21 November 2017 at 00:13, Andres Gomez <agomez at igalia.com> wrote:
>> > Jason, this nominated series landed without mentioning any specific
>> > stable queue.
>> >
>> > From what I'm seeing, both depend on 2c4097aff1b which didn't make it
>> > for 17.2 so I'm dropping them for that queue.
>> >
>> This is a preparatory patch for the follow-up commit.
>> With the latter addressing issue caused by
>> 4b1e70cc57d7ff5f465544644b2180dee1490cee - only available in
>> 17.4.0-dev.
>>
>> I believe the 17.2 and 17.3 series should be safe ;-)
>
>
> This bug goes all the way back.  It interacts with the patch mentioned but
> is not the same thing.  This patch (and the subsequent one) should probably
> go back as far as brw_bufmgr does.
Having a closer look at the patches related to external buffers, shows
the following:

2c4097aff1b i965: Only put external handles into the handle ht
17.3 only

d7a19d69ebc i965: Use PTE MOCS for all external buffers
17.4 + 17.3
4b1e70cc57d i965: Switch over to fully external-or-not MOCS scheme
17.4 only

344252a27f8 i965/bufmgr: Add a helper to mark a BO as external
0a6a137eb27 i965: Mark BOs as external when we export their handle
These fixes

With the above in mind, it seems that 4b1e70cc57d should have been
tagged for 17.3?

On the 17.2 front: Andres is right - commit 2c4097aff1b seems like a
bare minimum for this series.
Considering how well into the 17.2 series we are, I'm a bit worried
about picking if :-\

What do you guys think - are we save to leave the lot out for 17.2 or
it's an absolute must?

Thanks
Emil