[Mesa-stable] [Mesa-dev] [PATCHv2 3/4] configure.ac: Separate HAVE_LLVM defines for gallium and radv

[Dave Airlie]

On 2 February 2017 at 10:06, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 2 February 2017 at 00:00, Dave Airlie <airlied at gmail.com> wrote:
>> On 2 February 2017 at 09:58, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> On 1 February 2017 at 22:19, Dave Airlie <airlied at gmail.com> wrote:
>>>> Just make radv depend on enable-gallium-llvm.
>>>>
>>>> I really don't want to make the #defines into the spaghetti this introduces.
>>>>
>>> Not a huge fan of it either.
>>>
>>> We need these for 17.0 and flipping things in a feature freeze period
>>> is iffy. For 17.1.x we'll remove this and a lot more nasty code by
>>> superseding --enable-gallium-llvm in favour of --enable-llvm.
>>
>> Why do we need it, just make radv not build if enable-gallium-llvm
>> isn't specified.
>>
> Because that's the way things worked since day 1 - maybe it was an
> oversight, maybe a bug, other.
> All I'm asking is for a week or so of patience after which this messy
> code, plus more, will be gone. Please ?

It's going to make backporting stable fixes to 17.0 more error prone,
lots more error prone and I don't want that. Anything that touches
HAVE_LLVM vs MESA_HAVE_LLVM in the codebase, Not nice.

Who care what used to work, just make the reality sane for release.

If there is a bug report, close it saying just fix your build scripts.

Dave.