[Mesa-stable] [PATCH] anv: set input_slots_valid on brw_wm_prog_key

Lionel Landwerlin lionel.g.landwerlin at intel.com
Wed Jan 25 14:37:25 UTC 2017


On 25/01/17 14:34, Emil Velikov wrote:
> Hi Lionel,
>
> On 23 January 2017 at 17:10, Lionel Landwerlin
> <lionel.g.landwerlin at intel.com> wrote:
>> With shaders using a lot of inputs/outputs, like this (from Gtk+) :
>>
>> layout(location = 0) in vec2 inPos;
>> layout(location = 1) in float inGradientPos;
>> layout(location = 2) in flat int inRepeating;
>> layout(location = 3) in flat int inStopCount;
>> layout(location = 4) in flat vec4 inClipBounds;
>> layout(location = 5) in flat vec4 inClipWidths;
>> layout(location = 6) in flat ColorStop inStops[8];
>>
>> layout(location = 0) out vec4 outColor;
>>
>> we're missing the programming of the input_slots_valid field leading
>> to an assert further down the backend code.
>>
>> v2: Use valid slots of the geometry or vertex stage (Jason)
>>
>> v3: Use helper to find correct vue map (Jason)
>>
>> v4: Set the valid slots off the previous stages (Jason)
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>> Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
>> Cc: 13.0 17.0 <mesa-stable at lists.freedesktop.org>
> Spotted this a bit late, I'm afraid but will pick it up for the next round.
> Please please read through docs/submittingpatches.html#nominations for
> future nominations.
>
> Thanks
> Emil

Hi,

Thanks, will get it right next time!

-
Lionel


More information about the mesa-stable mailing list