[Mesa-stable] [PATCH] swr: modifications to allow gcc-4.8 compilation

Emil Velikov emil.l.velikov at gmail.com
Mon Jul 10 22:54:16 UTC 2017


On 10 July 2017 at 21:56, Rowley, Timothy O <timothy.o.rowley at intel.com> wrote:
>
>> On Jul 10, 2017, at 3:32 PM, Andres Gomez <agomez at igalia.com> wrote:
>
> Tim, I'm a bit confused with this patch.
>
> You landed in master:
> f0a22956be4802e01f2b4f3244f011212626f12d "swr/rast: _mm*_undefined_*
> implementations for gcc<4.9"
>
> And marked it for -stable picking but the patch in this mail also has
> changes that only apply to the stable branch.
>
> Is this a backport and I should use it instead of the patch which
> landed in master?
>
>
> This is the branch equivalent of these two patches:
>
> f0a22956be4802e01f2b4f3244f011212626f12d swr/rast: _mm*_undefined_*
> implementations for gcc<4.9
> d50ef7332c956785934336d757815196c48ac1d6 swr/rast: don't use _mm256_fmsub_ps
> in AVX code
>
> The simd intrinsics library we used has diverged significantly between
> branch and master; the non-“undefined intrinsics” portion is specific to the
> branch.
>
Tim, it'll be great if one can clearly point out backports as
mentioned in the docs [1].
Tl;Dr: git format-patch --subject-prefix=BACKPORT + add "(cherry
picked from commit $sha1_of_commit_in_master)" at the common of the
commit message.

It allows for easier tracking, regardless of the reason.
Best example: in the past we had a fix for a fix for a fix that was
picked for -stable ;-)

-Emil
https://www.mesa3d.org/submittingpatches.html#backports


More information about the mesa-stable mailing list