[Mesa-stable] [Mesa-dev] [PATCH 4/4] i965: Use prepare_external instead of make_shareable in setTexBuffer2

[Jason Ekstrand]

On Mon, Nov 13, 2017 at 7:33 AM, Emil Velikov <emil.l.velikov at gmail.com>
wrote:

> Hi Jason,
>
> I'm not too familiar with the spec in question, so just a minor
> question/suggestion below.
>
> On 8 November 2017 at 23:20, Jason Ekstrand <jason at jlekstrand.net> wrote:
>
> > +void
> > +intelReleaseTexBuffer(__DRIcontext *pDRICtx, GLint target,
> > +                      __DRIdrawable *dPriv)
> > +{
> > +   struct brw_context *brw = pDRICtx->driverPrivate;
> > +   struct gl_context *ctx = &brw->ctx;
> > +   struct gl_texture_object *tex_obj;
> > +   struct intel_texture_object *intel_tex;
> > +
> > +   tex_obj = _mesa_get_current_tex_object(ctx, target);
> > +   if (!tex_obj)
> > +      return;
> > +
> > +   _mesa_lock_texture(&brw->ctx, tex_obj);
> > +
> > +   intel_tex = intel_texture_object(tex_obj);
> > +   if (!intel_tex->mt)
> > +      return;
> Here we should be unlocking the texobj, right?
>

You are correct, sir.  Fixed locally.

--Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-stable/attachments/20171113/93417554/attachment.html>