[Mesa-stable] [PATCH] meson: remove incomplete build system from 17.3 release

Dylan Baker dylan at pnwbakers.com
Tue Nov 21 18:47:04 UTC 2017


Quoting Emil Velikov (2017-11-21 06:36:10)
> On 20 November 2017 at 23:47, Ian Romanick <idr at freedesktop.org> wrote:
> > On 11/16/2017 03:23 AM, Emil Velikov wrote:
> >> Hi Dylan,
> >>
> >> On 14 November 2017 at 23:06, Dylan Baker <dylan at pnwbakers.com> wrote:
> >>> This build system is rather incomplete in the 17.3 tree, multiple bugs
> >>> have been fixed, and there are a number of very visibly user facing
> >>> changes that have been made (changing the default buildtype, for
> >>> example). It's not shipped in the tarball, but I don't want to receive
> >>> bug reports about 17.3, 18.0 is the release that I hope to have the
> >>> meson build in shape for.
> >>>
> >>> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> >>
> >>>  81 files changed, 7717 deletions(-)
> >>
> >> We aim to keep stable nominations small.
> >
> > Yes, but it's not an absolute requirement.  Please accept this patch.
> >
> I've went ahead with the error() as mentioned earlier.
> If that's insufficient, we can pull the whole thing.
> 
> What do you think?
> 
> -Emil

Ultimately it doesn't really matter to me which solution we use, they both have
the same result: I don't have to close bugs as "wont fix" for meson build
problems in the 17.3 branch. Since the 'error()' patch is in already I'm fine
leaving it at that.

If the question is about the theory of what patches are pulled into the stable
branch: I do think that it's a bit pedantic to say "this patch is too large",
because while it is large it's also simple: it just removed a bunch of files
that aren't even distributed in the tarball and requires touching up no files
that are in the tarball.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-stable/attachments/20171121/67820407/attachment.sig>


More information about the mesa-stable mailing list