[Mesa-stable] [Mesa-dev] [PATCH 3/4] vulkan/wsi/wayland: Copy wl_proxy objects from oldSwapchain if available

Jason Ekstrand jason at jlekstrand.net
Wed Sep 27 15:30:33 UTC 2017


On Wed, Sep 27, 2017 at 1:53 AM, Daniel Stone <daniel at fooishbar.org> wrote:

> Hi,
>
> On 26 September 2017 at 23:55, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
> >  static void
> > -wsi_wl_display_destroy(struct wsi_wl_display *display)
> > +wsi_wl_display_ref(struct wsi_wl_display *display)
> > +{
> > +   display->refcount++;
> > +}
>
> Better:
> static struct wsi_wl_display *
> wsi_wl_display_ref(struct wsi_wl_display *display)
> {
>    display->refcount++;
>    return display;
> }
>
> Makes it much more difficult to get it wrong. :)
>

Yeah.  I thought about doing that the first time around but decided against
it for no good reason.  You've pushed me over the edge back into sanity. :)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-stable/attachments/20170927/bdd8001b/attachment.html>


More information about the mesa-stable mailing list