[Mesa-stable] A couple of nominated patches that are not on 18.0

Juan A. Suarez Romero jasuarez at igalia.com
Sat Apr 14 13:44:03 UTC 2018


On Fri, 2018-04-13 at 14:47 -0700, Dylan Baker wrote:
> Hi Juan,
> 
> I took Mark's scripts and diffed the branch they created with what is in your
> staging branch, and I noticed that these two patches were in Mark's, but not
> yours (this was the only real difference).
> 
> I'm pretty sure that the first one should be in stable, and I know that the
> second should. Do you have any idea why there aren't in stable?
> 

Are the commit IDs correct? Those commits do not appear in the master branch. I
guess they are the commit after cherry-picking them.

> d6741cd5b48 * configure: use AC_CHECK_HEADERS to check for endian.h 

This one was picked, but it was squashed in:

a602ef93524d9 meson/configure: detect endian.h instead of trying to guess when
it's available

I've squashed them because one was fixing the other, and IIRC one of them was
failing when compiling without the other.

>                                                                                                                                      
> 7fde27103e6 * meson: fix HAVE_LLVM version define in meson build
> 

This wasn't picked because it was mentioning a wrong commit id. In master, this
commit:

a2a1b0e75 meson: fix HAVE_LLVM version define in meson build

Fixes: e6418ab1566d ("meson: build "radv" vulkan driver for radeon hardware")
 
But turns out the commit id it fixes is wrong; it should be 673dda8330. Hence
why the script didn't catch it, and was missed.

At this point, we have two options: enqueue it and run again the CI, or just
postpone it for the next version. WDYT?


> Dylan


More information about the mesa-stable mailing list