[Mesa-stable] A couple of nominated patches that are not on 18.0
Dylan Baker
dylan at pnwbakers.com
Mon Apr 16 21:30:58 UTC 2018
Quoting Juan A. Suarez Romero (2018-04-14 07:12:18)
> On Sat, 2018-04-14 at 15:44 +0200, Juan A. Suarez Romero wrote:
> > On Fri, 2018-04-13 at 14:47 -0700, Dylan Baker wrote:
> > > Hi Juan,
> > >
> > > I took Mark's scripts and diffed the branch they created with what is in your
> > > staging branch, and I noticed that these two patches were in Mark's, but not
> > > yours (this was the only real difference).
> > >
> > > I'm pretty sure that the first one should be in stable, and I know that the
> > > second should. Do you have any idea why there aren't in stable?
> > >
> >
> > Are the commit IDs correct? Those commits do not appear in the master branch. I
> > guess they are the commit after cherry-picking them.
> >
> > > d6741cd5b48 * configure: use AC_CHECK_HEADERS to check for endian.h
> >
> > This one was picked, but it was squashed in:
> >
> > a602ef93524d9 meson/configure: detect endian.h instead of trying to guess when
> > it's available
> >
> > I've squashed them because one was fixing the other, and IIRC one of them was
> > failing when compiling without the other.
> >
Awesome, that makes sense.
> > >
> > > 7fde27103e6 * meson: fix HAVE_LLVM version define in meson build
> > >
> >
> > This wasn't picked because it was mentioning a wrong commit id. In master, this
> > commit:
> >
> > a2a1b0e75 meson: fix HAVE_LLVM version define in meson build
> >
> > Fixes: e6418ab1566d ("meson: build "radv" vulkan driver for radeon hardware")
> >
> > But turns out the commit id it fixes is wrong; it should be 673dda8330. Hence
> > why the script didn't catch it, and was missed.
> >
> > At this point, we have two options: enqueue it and run again the CI, or just
> > postpone it for the next version. WDYT?
> >
>
> Thinking about this, actually this patch only affects meson, so if it builds
> correctly there is no need for running again the CI.
>
> So I'll enqueue it in the stable relase.
>
>
> J.A.
Thanks!
Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-stable/attachments/20180416/2247e3cc/attachment.sig>
More information about the mesa-stable
mailing list