[Mesa-stable] [PATCH v2] configure.ac: add missing llvm dependencies to .pc files

Emil Velikov emil.l.velikov at gmail.com
Thu Jan 25 15:55:30 UTC 2018


On 25 January 2018 at 14:43, Chuck Atkins <chuck.atkins at kitware.com> wrote:
> v2: Only add as dependencies for gallium-osmesa and gallium-xlib
>
> CC: <mesa-stable at lists.freedesktop.org>
> Signed-of-by: Chuck Atkins <chuck.atkins at kitware.com>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

> ---
>  configure.ac | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index 7c1fbe0ed1..448bd3a6ba 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2780,6 +2780,12 @@ if test "x$enable_llvm" = xyes; then
>              fi
>          fi
>      fi
> +    if test "x$enable_glx" == xgallium-xlib; then
> +        GL_PC_LIB_PRIV="$GL_PC_LIB_PRIV $LLVM_LIBS"
> +    fi
> +    if test "x$enable_gallium_osmesa" = xyes; then
> +        OSMESA_PC_LIB_PRIV="$OSMESA_PC_LIB_PRIV $LLVM_LIBS"
> +    fi
I'm itching to add a comment above these two, since Eric brought it up.
Modulo any objections I'll squash it before pushing.

The following two targets embed the swr/llvmpipe driver into the final binary.

Adding LLVM_LIBS results in the LLVM library propagated in the
Libs.private of the respective .pc file.
With the latter of which used when static linking the respective
targets into other projects.

-Emil


More information about the mesa-stable mailing list