[Mesa-stable] [Mesa-dev] [PATCH] anv/pipeline: Don't look at blend state unless we have an attachment

Jason Ekstrand jason at jlekstrand.net
Fri Jan 26 09:46:01 UTC 2018


On Fri, Jan 26, 2018 at 1:09 AM, Alex Smith <asmith at feralinteractive.com>
wrote:

> That commit is "anv/pipeline: Don't assert on more than 32 samplers"?
> https://cgit.freedesktop.org/mesa/mesa/commit/?id=
> 4b69ba381766cd911eb1284f1b0332a139ec8a75
>

You're right.  I'm not sure what I was talking about.  I've dug the patch
out of patchwork and will push once it's done in Jenkins.

--Jason


> On 25 January 2018 at 22:53, Jason Ekstrand <jason at jlekstrand.net> wrote:
>
>> It landed as 4b69ba381766cd911eb1284f1b0332a139ec8a75
>>
>> On Thu, Jan 25, 2018 at 3:27 AM, Emil Velikov <emil.l.velikov at gmail.com>
>> wrote:
>>
>>> On 18 January 2018 at 01:16, Jason Ekstrand <jason at jlekstrand.net>
>>> wrote:
>>> > Without this, we may end up dereferencing blend before we check for
>>> > binding->index != UINT32_MAX.  However, Vulkan allows the blend state
>>> to
>>> > be NULL so long as you don't have any color attachments.  This fixes a
>>> > segfault when running The Talos Principal.
>>> >
>>> > Fixes: 12f4e00b69e724a23504b7bd3958fb75dc462950
>>> > Cc: mesa-stable at lists.freedesktop.org
>>> > ---
>>> Jason, did this fall through the cracks or it has been
>>> superseded/rejected for some reason?
>>>
>>> -Emil
>>>
>>
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-stable/attachments/20180126/cbde0d3e/attachment-0001.html>


More information about the mesa-stable mailing list