[Mesa-stable] [Mesa-dev] [PATCH] gallium/tests: Don't ignore S3TC errors.

Emil Velikov emil.l.velikov at gmail.com
Tue Jul 24 16:52:13 UTC 2018


On 24 July 2018 at 13:58, Jose Fonseca <jfonseca at vmware.com> wrote:
> Now we do full S3TC decompression they should no longer fail.
> ---
>  src/gallium/tests/unit/u_format_test.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/src/gallium/tests/unit/u_format_test.c b/src/gallium/tests/unit/u_format_test.c
> index 6de581fd049..437cc94b757 100644
> --- a/src/gallium/tests/unit/u_format_test.c
> +++ b/src/gallium/tests/unit/u_format_test.c
> @@ -380,11 +380,6 @@ test_format_unpack_rgba_8unorm(const struct util_format_description *format_desc
>     if (util_is_double_nan(test->unpacked[0][0][0]))
>        success = TRUE;
>
> -   /* Ignore S3TC errors */
> -   if (format_desc->layout == UTIL_FORMAT_LAYOUT_S3TC) {
> -      success = TRUE;
> -   }
> -
We normally want this in stable as well. The following provide a rough
relation to the commit effectively enabling the built-in S3TC.
Feel free to add it

Fixes: 34cf3c43bee ("mesa: Call DXTn functions directly")

-Emil


More information about the mesa-stable mailing list