[Mesa-stable] [PATCH 2/3] i965/vec4: Properly handle sign(-abs(x))
Ian Romanick
idr at freedesktop.org
Wed Jun 27 14:37:58 UTC 2018
From: Ian Romanick <ian.d.romanick at intel.com>
This is achived by copying the sign(abs(x)) optimization from the FS
backend.
On Gen7 an earlier platforms, this fixes new piglit tests:
- glsl-1.10/execution/vs-sign-neg-abs.shader_test
- glsl-1.10/execution/vs-sign-sat-neg-abs.shader_test
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Cc: mesa-stable at lists.freedesktop.org
---
src/intel/compiler/brw_vec4_nir.cpp | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/src/intel/compiler/brw_vec4_nir.cpp b/src/intel/compiler/brw_vec4_nir.cpp
index 7131fa06b4a..34034caccd0 100644
--- a/src/intel/compiler/brw_vec4_nir.cpp
+++ b/src/intel/compiler/brw_vec4_nir.cpp
@@ -1806,7 +1806,23 @@ vec4_visitor::nir_emit_alu(nir_alu_instr *instr)
unreachable("not reached: should have been lowered");
case nir_op_fsign:
- if (type_sz(op[0].type) < 8) {
+ if (op[0].abs) {
+ /* Straightforward since the source can be assumed to be either
+ * strictly >= 0 or strictly <= 0 depending on the setting of the
+ * negate flag.
+ */
+ inst = emit(MOV(dst, op[0]));
+ inst->conditional_mod = BRW_CONDITIONAL_NZ;
+
+ inst = (op[0].negate)
+ ? emit(MOV(dst, brw_imm_f(-1.0f)))
+ : emit(MOV(dst, brw_imm_f(1.0f)));
+ inst->predicate = BRW_PREDICATE_NORMAL;
+
+ if (instr->dest.saturate)
+ inst->saturate = true;
+
+ } else if (type_sz(op[0].type) < 8) {
/* AND(val, 0x80000000) gives the sign bit.
*
* Predicated OR ORs 1.0 (0x3f800000) with the sign bit if val is not
--
2.14.4
More information about the mesa-stable
mailing list