[Mesa-stable] [Mesa-dev] [PATCH] radv: Fix CmdCopyImage between uncompressed and compressed images

Dave Airlie airlied at gmail.com
Tue Mar 13 19:14:05 UTC 2018


On 13 March 2018 at 01:38, Alex Smith <asmith at feralinteractive.com> wrote:
> From the spec:
>
>     "When copying between compressed and uncompressed formats the
>      extent members represent the texel dimensions of the source
>      image and not the destination."
>
> However, as per 7b890a36, we must still use the destination image type
> when clamping the extent so that we copy the correct number of layers
> for 2D to 3D copies.
>
> Fixes: 7b890a36 "radv: Fix vkCmdCopyImage for 2d slices into 3d Images"
> Cc: <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Alex Smith <asmith at feralinteractive.com>

Reviewed-by: Dave Airlie <airlied at redhat.com>

Might be worth filing a cts issue to see if someone wants to write
tests for this sort of hole.

Dave.


More information about the mesa-stable mailing list