[Mesa-stable] [PATCH] mesa: fix glGetInteger/Float/etc queries for vertex arrays attribs

Brian Paul brianp at vmware.com
Fri May 11 12:26:37 UTC 2018


On 05/11/2018 03:51 AM, Juan A. Suarez Romero wrote:
> On Wed, 2018-05-09 at 19:51 -0600, Brian Paul wrote:
>> The vertex array Size and Stride attributes are now ubyte and short,
>> respectively.  The glGet code needed to be updated to handle those
>> types, but wasn't.
>>
>> Fixes the new piglit test gl-1.5-get-array-attribs test.
>>
>> Bugzilla: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D106450&d=DwICaQ&c=uilaK90D4TOVoH58JNXRgQ&r=Ie7_encNUsqxbSRbqbNgofw0ITcfE8JKfaUjIQhncGA&m=UiMSw582Jyda8hb5bMjFvA5YnjycFZvNEg-XV3XkgR8&s=xrYXXcUiUfyIya8IE0wGTxl0FQoLbLKk-BKwePoIDRg&e=
>> Fixes: d5f42f96e16 ("mesa: shrink size of gl_array_attributes (v2)")
>> Cc: mesa-stable at lists.freedesktop.org
> 
> 
> This commit was nominated for inclusion to stable, but at the same time it has
> the "Fixes" tag.
> 
> My understanding is that this patch does not make sense if the branch doesn't
> include the commit it fixes.
> 
> In the case of 18.0 stable branch, commit d5f42f96e16 is not there, so I
> understand this nominated patch shouldn't be included neither. Thus, I'll reject
> it for 18.0.
> 
> If you think it should be included anyway, just sent a new patch that can be
> applied in 18.0.
> 
> Thank you.

OK, no problem.  I was assuming the 18.0 branch was created after Jan 
19, but evidently it was made before.

-Brian




More information about the mesa-stable mailing list