[Mesa-stable] [PATCH 1/2] st/nine: do not double-close the fd on teardown

Juan A. Suarez Romero jasuarez at igalia.com
Mon Oct 1 08:49:14 UTC 2018


On Wed, 2018-08-29 at 18:13 +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> As the newly introduced comment says:
>  The pipe loader takes ownership of the fd
> 
> Thus, there's no need to close it again.


This patch seems to be already reviewed, but not pushed to upstream. 


	J.A.

> 
> Cc: Patrick Rudolph <siro at das-labor.org>
> Cc: Axel Davy <davyaxel0 at gmail.com>
> Cc: mesa-stable at lists.freedesktop.org>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  src/gallium/targets/d3dadapter9/drm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/targets/d3dadapter9/drm.c b/src/gallium/targets/d3dadapter9/drm.c
> index 85b3e10633e..a2a36dbbda9 100644
> --- a/src/gallium/targets/d3dadapter9/drm.c
> +++ b/src/gallium/targets/d3dadapter9/drm.c
> @@ -107,7 +107,7 @@ drm_destroy( struct d3dadapter9_context *ctx )
>      if (drm->dev)
>          pipe_loader_release(&drm->dev, 1);
>  
> -    close(drm->fd);
> +    /* The pipe loader takes ownership of the fd */
>      FREE(ctx);
>  }
>  



More information about the mesa-stable mailing list