[Mesa-stable] [Mesa-dev] [PATCH] i965: Don't bother to call blorp if the blit is zero-sized

[Vadim Shovkoplias]

Hi Jason,

I'm still getting crash with this patch when run conformance test in the
firefox.
Assert is triggered during following call:

glBlitFramebuffer(srcX0 = -1, srcY0 = -1, srcX1 = 2147483646, srcY1 =
2147483646, dstX0 = 0, dstY0 = 0, dstX1 = 8, dstY1 = 8, mask =
GL_COLOR_BUFFER_BIT, filter = GL_NEAREST)

пн, 1 окт. 2018 г. в 12:50, Juan A. Suarez Romero <jasuarez at igalia.com>:

> On Tue, 2018-09-11 at 11:15 -0500, Jason Ekstrand wrote:
> > Cc: mesa-stable at lists.freedesktop.org
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107892
> > ---
> >  src/mesa/drivers/dri/i965/brw_meta_util.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
>
> This has been reviewed, but not pushed yet.
>
>
>         J.A.
>
> > diff --git a/src/mesa/drivers/dri/i965/brw_meta_util.c
> b/src/mesa/drivers/dri/i965/brw_meta_util.c
> > index 908b0989769..6714d96237c 100644
> > --- a/src/mesa/drivers/dri/i965/brw_meta_util.c
> > +++ b/src/mesa/drivers/dri/i965/brw_meta_util.c
> > @@ -247,6 +247,9 @@ brw_meta_mirror_clip_and_scissor(const struct
> gl_context *ctx,
> >                      clip_src_y1, clip_dst_y1, clip_dst_y0,
> >                      scaleY, false);
> >
> > +   if (*dstX0 == *dstX1 || *dstY0 == *dstY1)
> > +      return true;
> > +
> >     /* Account for the fact that in the system framebuffer, the origin
> is at
> >      * the lower left.
> >      */
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-stable/attachments/20181001/ea28809d/attachment.html>