[Mesa-stable] [Mesa-dev] [PATCH] vulkan: Disable randr lease for libxcb < 1.13

Juan A. Suarez Romero jasuarez at igalia.com
Tue Oct 2 07:47:31 UTC 2018


On Tue, 2018-10-02 at 08:23 +1000, Stuart Young wrote:
> Just a follow-up to make sure this makes it into mesa-stable.
> 
> I know the release window for 18.2.2 is coming up.
> 

This was already enqueued for 18.2.

	J.A.

> 
> On Thu, 27 Sep 2018 at 16:32, Dave Airlie <airlied at gmail.com> wrote:
> > On Thu, 27 Sep 2018 at 15:40, Stuart Young <cefiar at gmail.com> wrote:
> > >
> > > Hi All,
> > >
> > > Can we get some feedback on this patch please?
> > >
> > > At the moment, we can't compile vulkan using libxcb < 1.13 due to the use of the RandR lease mechanism. Dave Airlie (cc'd) did some work previously to allow things to be compiled with libxcb 1.11/1.12, mainly by ifdef'ing certain code with HAVE_DRI3_MODIFIERS so that it would compile, but without the extra features that xcb 1.13+ provides. See commit 7aeef2d4efdc809a698e "dri3: allow building against older xcb (v3)" for that.
> > >
> > > The patch (originally provided by Maxime) appears to solve the new build issue, and in much the same way as Dave Airlie did with his previous patch.
> > >
> > > Note: If we "must have" xcb 1.13, then that's fine. But if that is the case, then we need to update mesa's build deps so that this is explicit (ie: effectively reverting Dave Airlie's commits on the issue).
> > >
> > 
> > Pushed it, was building on old Ubuntu yesterday and forgot to actually
> > push it back out.
> > 
> > Dave.
> 
> 
> _______________________________________________
> mesa-stable mailing list
> mesa-stable at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-stable



More information about the mesa-stable mailing list