[Mesa-stable] [PATCH 2/2] anv: Support v3 of VK_EXT_vertex_attribute_divisor

[Jason Ekstrand]

This should go into 18.2 which means also back-porting the header update
which shouldn't be a big deal.  I have a feeling DXVK will add a hard
requirement on v3 fairly shortly so it would be good if it works in
released mesa.

On Mon, Sep 10, 2018 at 1:44 PM Jason Ekstrand <jason at jlekstrand.net> wrote:

> On Mon, Sep 10, 2018 at 1:43 PM Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
> wrote:
>
>> I tried, but I can't find from your driver what the HW does, so for
>> this review the same assumption that the CTS tests pass for you.
>>
>
> Our hardware does the DX thing which is also what the spec says.  Yes, we
> pass the tests.
>
> Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
>>
>
> Thanks!
>
>
>> On Mon, Sep 10, 2018 at 7:08 PM Jason Ekstrand <jason at jlekstrand.net>
>> wrote:
>> >
>> > Cc: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
>> > ---
>> >  src/intel/vulkan/anv_device.c      | 8 ++++++++
>> >  src/intel/vulkan/anv_extensions.py | 2 +-
>> >  2 files changed, 9 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/src/intel/vulkan/anv_device.c
>> b/src/intel/vulkan/anv_device.c
>> > index 7ab8543300b..44855dae128 100644
>> > --- a/src/intel/vulkan/anv_device.c
>> > +++ b/src/intel/vulkan/anv_device.c
>> > @@ -934,6 +934,14 @@ void anv_GetPhysicalDeviceFeatures2(
>> >           break;
>> >        }
>> >
>> > +      case
>> VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VERTEX_ATTRIBUTE_DIVISOR_FEATURES_EXT: {
>> > +         VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT *features =
>> > +            (VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT *)ext;
>> > +         features->vertexAttributeInstanceRateDivisor = VK_TRUE;
>> > +         features->vertexAttributeInstanceRateZeroDivisor = VK_TRUE;
>> > +         break;
>> > +      }
>> > +
>> >        default:
>> >           anv_debug_ignored_stype(ext->sType);
>> >           break;
>> > diff --git a/src/intel/vulkan/anv_extensions.py
>> b/src/intel/vulkan/anv_extensions.py
>> > index a21aee5a001..951505a854e 100644
>> > --- a/src/intel/vulkan/anv_extensions.py
>> > +++ b/src/intel/vulkan/anv_extensions.py
>> > @@ -122,7 +122,7 @@ EXTENSIONS = [
>> >                'device->has_context_priority'),
>> >      Extension('VK_EXT_shader_viewport_index_layer',       1, True),
>> >      Extension('VK_EXT_shader_stencil_export',             1,
>> 'device->info.gen >= 9'),
>> > -    Extension('VK_EXT_vertex_attribute_divisor',          2, True),
>> > +    Extension('VK_EXT_vertex_attribute_divisor',          3, True),
>> >      Extension('VK_EXT_post_depth_coverage',               1,
>> 'device->info.gen >= 9'),
>> >      Extension('VK_EXT_sampler_filter_minmax',             1,
>> 'device->info.gen >= 9'),
>> >  ]
>> > --
>> > 2.17.1
>> >
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-stable/attachments/20180910/4307235c/attachment.html>