[Mesa-stable] [PATCH v2] st: require compatible driver in autotools

Emil Velikov emil.l.velikov at gmail.com
Tue Apr 23 10:41:17 UTC 2019


On Fri, 19 Apr 2019 at 19:53, Alyssa Ross <hi at alyssa.is> wrote:
>
> The meson build system already has these checks. I've just copied them
> to autotools.
>
> Without this, state trackers could be enabled when building with the
> following set of options, which resulted in a compile error due to VL
> being built without DRM.
>
>      --enable-autotools
>      --with-platforms=x11
>      --with-dri-drivers=
>      --with-gallium-drivers=swrast
>      --disable-glx
>      --disable-dri3
>      --disable-gbm
>
> The compile error was:
>
>     vl/vl_winsys_dri.c:36:10: fatal error: xf86drm.h: No such file or directory
>      #include <xf86drm.h>
>               ^~~~~~~~~~~
>     compilation terminated.
>
I was in favour of the the explicit driver/st tracking yet it was
nuked with commit 28e84c93bb33dfc8ac5219480b274c84dbd58762
To address the above use-case, we don't need to reinstate the tracking
- it causes a lot of churn.

Off the top of my head - none of the VL code should be build when we
have only a swrast driver.
Can you try and kill that bug, or shall I?

-Emil


More information about the mesa-stable mailing list