[Mesa-stable] [Mesa-dev] [PATCH] st/glsl_to_nir: fix incorrect arrary access
Timothy Arceri
tarceri at itsqueeze.com
Mon Mar 25 21:46:49 UTC 2019
On 26/3/19 3:43 am, Emil Velikov wrote:
> Hi Timothy,
>
> On Fri, 1 Mar 2019 at 10:36, Timothy Arceri <tarceri at itsqueeze.com> wrote:
>>
>> This fixes a segfault when we try to access the array using a
>> -1 when the array wasn't allocated in the first place.
>>
>> Before 7536af670b75 we would just access a pre-allocated array
>> that was also load/stored to/from the shader cache. But now the
>> cache will no longer allocate these arrays if they are empty.
>> The change resulted in tests such as the following segfaulting
>> when run with a warm shader cache.
>>
> I was going through some extra checks for 18.3 and noticed this commit.
>
> Admittedly it does not fix 7536af670b75 although it does address a
> preexisting issue exposed by it.
> That said I suspect we'd want this for stable?
This fixes an issue that is not part of the default path of any drivers
so I'm happy to skip back porting to stable.
More information about the mesa-stable
mailing list