[Mesa-stable] [PATCH] d3dadapter9: Revert to old throttling limit value

Juan A. Suarez Romero jasuarez at igalia.com
Thu May 30 10:48:42 UTC 2019


On Thu, 2019-05-30 at 12:42 +0200, Axel Davy wrote:
> On 30/05/2019 12:33, Juan A. Suarez Romero wrote:
> > On Sun, 2019-05-26 at 23:23 +0200, Axel Davy wrote:
> > > Recently PIPE_CAP_MAX_FRAMES_IN_FLIGHT was changed from 2
> > > to 1:
> > > 20909284f204091757c050aa40cfffaf3f981b9c
> > > 
> > > No driver seems to overwrite the default value.
> > > 
> > > One user reports severe regressions for some games.
> > > For now, revert to the value 2 for nine.
> > > 
> > Axel, I guess this patch is specifically for stable branches, as I didn't see it
> > in @dev list, correct?
> 
> Hi, I must have done something wrong then, I intended to have it also in 
> @dev.
> 

In that case, I'll wait until the revert reaches master, so we have also a R-b.

	J.A.

> 
> > 
> > Also, I guess this patch is specifically for 19.1 branch, right?
> 
> Yes indeed, it doesn't need to apply to 19.0.
> 
> Yours,
> 
> 
> Axel Davy
> 
> > 
> > 	J.A.
> > 
> > > Cc: mesa-stable at lists.freedesktop.org
> > > 
> > > Signed-off-by: Axel Davy <davyaxel0 at gmail.com>
> > > ---
> > >   src/gallium/targets/d3dadapter9/drm.c | 6 ++++--
> > >   1 file changed, 4 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/src/gallium/targets/d3dadapter9/drm.c b/src/gallium/targets/d3dadapter9/drm.c
> > > index b0b9bb12f2c..657c619ac42 100644
> > > --- a/src/gallium/targets/d3dadapter9/drm.c
> > > +++ b/src/gallium/targets/d3dadapter9/drm.c
> > > @@ -243,8 +243,10 @@ drm_create_adapter( int fd,
> > >           return D3DERR_DRIVERINTERNALERROR;
> > >       }
> > >   
> > > -    ctx->base.throttling_value =
> > > -       ctx->base.hal->get_param(ctx->base.hal, PIPE_CAP_MAX_FRAMES_IN_FLIGHT);
> > > +    /* Previously was set to PIPE_CAP_MAX_FRAMES_IN_FLIGHT,
> > > +     * but the change of value of this cap to 1 seems to cause
> > > +     * regressions. */
> > > +    ctx->base.throttling_value = 2;
> > >       ctx->base.throttling = ctx->base.throttling_value > 0;
> > >   
> > >       driParseOptionInfo(&defaultInitOptions, __driConfigOptionsNine);
> 
> 



More information about the mesa-stable mailing list