On May 31, 2016 2:50 PM, "Ilia Mirkin" <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>> wrote: > > With the introduction of fp64 and fp16 to nir, there are now a bunch of > float types running around. A F1 2015 shader ends up with an i2f.sat > operation, which has a nir_type_float32 destination. Allow sat on all > the float destination types. > > Signed-off-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>> > Cc: "12.0" <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>> > --- > src/compiler/nir/nir_validate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/nir/nir_validate.c b/src/compiler/nir/nir_validate.c > index 35bb162..8404e11 100644 > --- a/src/compiler/nir/nir_validate.c > +++ b/src/compiler/nir/nir_validate.c > @@ -331,7 +331,7 @@ validate_alu_dest(nir_alu_instr *instr, validate_state *state) > * destinations of type float > */ > nir_alu_instr *alu = nir_instr_as_alu(state->instr); > - validate_assert(state, nir_op_infos[alu->op].output_type == nir_type_float || > + validate_assert(state, nir_op_infos[alu->op].output_type & nir_type_float || We have a nir_alu_type_get_base_type helper function which would probably be more appropriate than the &. With that changed, Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> > !dest->saturate); > > unsigned bit_size = dest->dest.is_ssa ? dest->dest.ssa.bit_size > -- > 2.7.3 > > _______________________________________________ > mesa-dev mailing list > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> > <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a>