<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> </head> <body> <meta content="text/html; charset=UTF-8"> <style type="text/css" style="">  </style> <div dir="ltr"> <div id="x_divtagdefaultwrapper" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif"> Hi Emil, I have added comments for each patch, and applied for branch 12.0. Please find attached patches. Thanks, Sonny </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr">From: mesa-dev <mesa-dev-bounces@lists.freedesktop.org> on behalf of Christian König <deathsimple@vodafone.de> Sent: Friday, July 1, 2016 8:07:51 AM To: Emil Velikov Cc: Jiang, Sonny; 12.0; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu <div> </div> </div> </div> <div class="PlainText">Am 01.07.2016 um 13:14 schrieb Emil Velikov: > Hi all, > > On 29 June 2016 at 20:20, Christian König <deathsimple@vodafone.de> wrote: >> Am 29.06.2016 um 18:35 schrieb Alex Deucher: >>> On Wed, Jun 29, 2016 at 11:38 AM, Leo Liu <leo.liu@amd.com> wrote: >>>> From: sonjiang <sonny.jiang@amd.com> >>>> >>>> Signed-off-by: sonjiang <sonny.jiang@amd.com> >>>> Cc: "12.0" <mesa-stable@lists.freedesktop.org> >>> For the series: >>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> >> >> Reviewed-by: Christian König <christian.koenig@amd.com> as well. >> > Here we have three patches, suggesting a bug with absolutely no > information what the issue is and/or why this approach is correct. > > I'm sorry to say this, but as is, this series is not landing in > stable. Sonjiang, being the author of these please reply with a brief > justification why we want those. Before doing so I would strongly > recommend reading this [1] blog post. Well to put a carrot on the front of your stick: I asked what the firmware version patch is all about internally as well when I've seen those patches. So it would have even made our internal review much easier if Sonny added a commit message in the first place. My fault to not requesting that his answer is put as a commit message on the patches. On the other hand this is for Polaris, we had time pressure to get it out of the door and today is a public holiday in Canada. So you probably won't get updated message before Monday. Is that soon enough? Otherwise UVD will be broken on Polaris in the stable branch. Regards, Christian. > > Thanks > Emil > > [1] <a href="http://who-t.blogspot.co.uk/2009/12/on-commit-messages.html">http://who-t.blogspot.co.uk/2009/12/on-commit-messages.html</a> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </div> </body> </html>