<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;"> AFAICS, this code is only used when USE_X86_ASM/USE_X86_64_ASM. These are never defined on Windows (we never use the assembly files on Windows, regardless which compiler is used), therefore there should be no impact to MSVC or Windows builds. Acked-by: Jose Fonseca <jfonseca@vmware.com> Jose <div> </div> PS: Thanks for CC'ing me. Please feel free to do so whenever feedback concerning MSVC/Windows build is sought. <div style="color: rgb(0, 0, 0);"> <div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr">From: Emil Velikov <emil.l.velikov@gmail.com> Sent: Tuesday, July 19, 2016 12:41 To: Matt Turner; Brian Paul; Jose Fonseca Cc: mesa-dev@lists.freedesktop.org; 9.2 Subject: Re: [Mesa-stable] [PATCH] mapi: Massage code to allow clang to compile. <div> </div> </div> </div> <div class="PlainText">On 18 July 2016 at 21:54, Matt Turner <mattst88@gmail.com> wrote: > On Mon, Jul 11, 2016 at 10:49 AM, Matt Turner <mattst88@gmail.com> wrote: >> According to <a href="https://llvm.org/bugs/show_bug.cgi?id=19778#c3" id="LPlnk430253"> https://llvm.org/bugs/show_bug.cgi?id=19778#c3</a> this code >> was violating the spec, resulting in it failing to compile. >> >> Cc: mesa-stable@lists.freedesktop.org >> Co-authored-by: Tomasz Paweł Gajc <tpgxyz@gmail.com> >> Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=89599">https://bugs.freedesktop.org/show_bug.cgi?id=89599</a> >> --- >> I've tried for months to reproduce this, and I've still never been >> able to on 64-bit builds. I can reproduce it on 32-bit however. >> >> On MSVC, this patch will have the effect of changing the variables >> from static to extern. I do not know if this will adversely affect >> anything, so this patch would benefit from MSVC testing. > > Ping... As mentioned before I'm not sure if C11 text should be applicable, considering we're explicitly using c99/gnu99. That said it doesn't make things explode afaics so let's merge it. Reviewed-by: Emil Velikov <emil.velikov@collabora.com> The Windows build and tests to pass on AppVeyor [1] but the patch could use some real world testing. Brian, Jose ? Thanks Emil [1] <a href="https://ci.appveyor.com/project/evelikov/mesa-4up2g">https://ci.appveyor.com/project/evelikov/mesa-4up2g</a> </div> </div> </div> </body> </html>