On Nov 11, 2016 6:16 AM, "Ilia Mirkin" <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>> wrote: > > I haven't checked spirv for the specific naming, but note that prim ID can be an output in gs. You're right. I'm not 100% site how we handle that today. We probably just pass it through as a varying. It looks like the code here needs to be a bit more complex. > > On Nov 11, 2016 1:34 AM, "Jason Ekstrand" <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote: >> >> Before, we were treating it as an output which is just completely bogus. >> We could go for an input but a system value makes more sense. >> >> Cc: "13.0" <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>> >> --- >> src/compiler/spirv/vtn_variables.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c >> index bbcca14..a4d5367 100644 >> --- a/src/compiler/spirv/vtn_variables.c >> +++ b/src/compiler/spirv/vtn_variables.c >> @@ -806,8 +806,8 @@ vtn_get_builtin_location(struct vtn_builder *b, >> set_mode_system_value(mode); >> break; >> case SpvBuiltInPrimitiveId: >> - *location = VARYING_SLOT_PRIMITIVE_ID; >> - *mode = nir_var_shader_out; >> + *location = SYSTEM_VALUE_PRIMITIVE_ID; >> + set_mode_system_value(mode); >> break; >> case SpvBuiltInInvocationId: >> *location = SYSTEM_VALUE_INVOCATION_ID; >> -- >> 2.5.0.400.gff86faf >> >> _______________________________________________ >> mesa-dev mailing list >> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> >> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a>