<div dir="auto">I am waiting to have time to do proper testing on the patch like I promised. Thus far, the time to do so has failed to materialize.</div><div class="gmail_extra"> <div class="gmail_quote">On Mar 14, 2017 8:27 AM, "Emil Velikov" <<a href="mailto:emil.l.velikov@gmail.com">emil.l.velikov@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ilia, are you waiting for another person to review the patch or it's no longer applicable ? Thanks Emil On 10 March 2017 at 11:07, Marek Olšák <<a href="mailto:maraeo@gmail.com">maraeo@gmail.com</a>> wrote: > Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>> > > Marek > > On Sat, Mar 4, 2017 at 7:52 PM, Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>> wrote: >> This prevents textureQueryLevels, which maps as LODQ, from ending up >> with a xyzw writemask, which is illegal. >> >> Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=100061" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=100061</a> >> Signed-off-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>> >> Cc: <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a> >> --- >> >> Untested beyond making sure that the shader in the above bug ends up with >> a .xy writemask. I don't have access to a reasonable testing rig right now, >> would be ideal if someone could give it a run through theirs... >> >> src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp >> index af41bdb..63b681f 100644 >> --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp >> +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp >> @@ -4165,6 +4165,7 @@ glsl_to_tgsi_visitor::visit(ir_texture *ir) >> */ >> result_src = get_temp(ir->type); >> result_dst = st_dst_reg(result_src); >> + result_dst.writemask = (1 << ir->type->vector_elements) - 1; >> >> switch (ir->op) { >> case ir_tex: >> -- >> 2.10.2 >> >> _______________________________________________ >> mesa-stable mailing list >> <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a> >> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-stable" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-stable</a> > _______________________________________________ > mesa-stable mailing list > <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a> > <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-stable" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-stable</a> </blockquote></div></div>