<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 14 March 2017 at 20:56, Bas Nieuwenhuizen <span dir="ltr"><<a href="mailto:bas@basnieuwenhuizen.nl" target="_blank">bas@basnieuwenhuizen.nl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The flushes could be due to TRANSFER barriers.<br>
<br>
Signed-off-by: Bas Nieuwenhuizen <<a href="mailto:basni@google.com">basni@google.com</a>><br>
Cc: 17.0 <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.<wbr>freedesktop.org</a>><br></blockquote><div><br></div><div>Hi Bas,<div><br></div><div>Are these needed? <span style="color:rgb(0,0,0);font-size:13.3333px">si_cp_dma_prepare already does a flush. That's why I didn't add a flush to this path on my last patch.</span></div><div><span style="color:rgb(0,0,0);font-size:13.3333px"><br></span></div><div><span style="color:rgb(0,0,0);font-size:13.3333px">Thanks,</span></div><div><span style="color:rgb(0,0,0);font-size:13.3333px">Alex</span></div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
 src/amd/vulkan/si_cmd_buffer.c | 3 +++<br>
 1 file changed, 3 insertions(+)<br>
<br>
diff --git a/src/amd/vulkan/si_cmd_<wbr>buffer.c b/src/amd/vulkan/si_cmd_<wbr>buffer.c<br>
index 5d35287f8e3..b808052ddb2 100644<br>
--- a/src/amd/vulkan/si_cmd_<wbr>buffer.c<br>
+++ b/src/amd/vulkan/si_cmd_<wbr>buffer.c<br>
@@ -998,6 +998,7 @@ void si_cp_dma_buffer_copy(struct radv_cmd_buffer *cmd_buffer,<br>
        uint64_t main_src_va, main_dest_va;<br>
        uint64_t skipped_size = 0, realign_size = 0;<br>
<br>
+       si_emit_cache_flush(cmd_<wbr>buffer);<br>
<br>
        if (cmd_buffer->device->physical_<wbr>device->rad_info.family <= CHIP_CARRIZO ||<br>
            cmd_buffer->device->physical_<wbr>device->rad_info.family == CHIP_STONEY) {<br>
@@ -1061,6 +1062,8 @@ void si_cp_dma_clear_buffer(struct radv_cmd_buffer *cmd_buffer, uint64_t va,<br>
<br>
        assert(va % 4 == 0 && size % 4 == 0);<br>
<br>
+       si_emit_cache_flush(cmd_<wbr>buffer);<br>
+<br>
        while (size) {<br>
                unsigned byte_count = MIN2(size, CP_DMA_MAX_BYTE_COUNT);<br>
                unsigned dma_flags = 0;<br>
<span class="gmail-HOEnZb"><font color="#888888">--<br>
2.12.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>