<div dir="ltr">Oh, hey, I should have read patch 2... That said, I think I like just calling anv_cmd_state_reset a little better.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 28, 2017 at 5:19 PM, Lionel Landwerlin <span dir="ltr"><<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 29/09/17 01:05, Lionel Landwerlin wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Valgrind stats on<br>
dEQP-VK.pipeline.push_constant<wbr>.graphics_pipeline.range_size_<wbr>128 :<br>
</blockquote>
<br>
I obviously inverted before & after...<div class="HOEnZb"><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Before:<br>
HEAP SUMMARY:<br>
in use at exit: 2,467,381 bytes in 1,304 blocks<br>
total heap usage: 697,853 allocs, 696,531 frees, 138,466,600 bytes allocated<br>
<br>
LEAK SUMMARY:<br>
definitely lost: 936 bytes in 10 blocks<br>
indirectly lost: 24,669 bytes in 412 blocks<br>
possibly lost: 0 bytes in 0 blocks<br>
still reachable: 2,441,776 bytes in 882 blocks<br>
suppressed: 0 bytes in 0 blocks<br>
<br>
After:<br>
HEAP SUMMARY:<br>
in use at exit: 2,467,513 bytes in 1,305 blocks<br>
total heap usage: 697,853 allocs, 696,530 frees, 138,466,600 bytes allocated<br>
<br>
LEAK SUMMARY:<br>
definitely lost: 1,068 bytes in 11 blocks<br>
indirectly lost: 24,669 bytes in 412 blocks<br>
possibly lost: 0 bytes in 0 blocks<br>
still reachable: 2,441,776 bytes in 882 blocks<br>
suppressed: 0 bytes in 0 blocks<br>
<br>
Signed-off-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a><wbr>><br>
Cc: "17.2 17.1" <<a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop<wbr>.org</a>><br>
---<br>
src/intel/vulkan/anv_cmd_buffe<wbr>r.c | 4 ++++<br>
1 file changed, 4 insertions(+)<br>
<br>
diff --git a/src/intel/vulkan/anv_cmd_buf<wbr>fer.c b/src/intel/vulkan/anv_cmd_buf<wbr>fer.c<br>
index 2ef7f9bf260..3509acaec0a 100644<br>
--- a/src/intel/vulkan/anv_cmd_buf<wbr>fer.c<br>
+++ b/src/intel/vulkan/anv_cmd_buf<wbr>fer.c<br>
@@ -289,6 +289,10 @@ anv_cmd_buffer_destroy(struct anv_cmd_buffer *cmd_buffer)<br>
vk_free(&cmd_buffer->pool->al<wbr>loc, state->push_descriptors[i]);<br>
}<br>
}<br>
+ for (uint32_t i = 0; i < MESA_SHADER_STAGES; i++) {<br>
+ if (state->push_constants[i] != NULL)<br>
+ vk_free(&cmd_buffer->pool->al<wbr>loc, state->push_constants[i]);<br>
+ }<br>
vk_free(&cmd_buffer->pool->al<wbr>loc, state->attachments);<br>
vk_free(&cmd_buffer->pool->al<wbr>loc, cmd_buffer);<br>
</blockquote>
<br>
<br></div></div><div class="HOEnZb"><div class="h5">
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div>