<div dir="ltr">Hi, minor self-review and correction the needed header is "xmlpool/options.h"<div>Only changes needed are in the commit title ...<br><div class="gmail_extra"><br><div class="gmail_quote">2017-12-18 0:11 GMT+01:00 Mauro Rossi <span dir="ltr"><<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">target.c requires "xmlpool/options.h" generated header<br></blockquote><div><br></div><div>...and here</div><div><br></div><div>target.c requires "util/options.h" generated header<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
or the following tricky Android building error may appear:<br>
<br>
In file included from external/mesa/src/gallium/<wbr>targets/dri/target.c:1:<br>
In file included from external/mesa/src/gallium/<wbr>auxiliary/target-helpers/drm_<wbr>helper.h:185:<br>
out/target/product/x86_64/gen/<wbr>STATIC_LIBRARIES/libmesa_pipe_<wbr>radeonsi_intermediates/<wbr>radeonsi/si_driinfo.h:19:7: error: expected '}'<br>
      DRI_CONF_RADEONSI_ENABLE_<wbr>SISCHED("false")<br>
      ^<br>
external/mesa/src/gallium/<wbr>auxiliary/target-helpers/drm_<wbr>helper.h:182:55: note: to match this '{'<br>
   static const struct drm_conf_ret xml_options_ret = {<br>
                                                      ^<br>
1 error generated.<br>
<br>
Fixes: 0f8c5de869 ("radeonsi: prepare for driver-specific driconf options")<br>
<br>
Cc: "17.3" <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.<wbr>freedesktop.org</a>><br>
---<br>
 src/gallium/targets/dri/<wbr>Android.mk | 4 ++--<br>
 1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/gallium/targets/dri/<wbr>Android.mk b/src/gallium/targets/dri/<wbr>Android.mk<br>
index d9923043af..a5b5f92ea0 100644<br>
--- a/src/gallium/targets/dri/<wbr>Android.mk<br>
+++ b/src/gallium/targets/dri/<wbr>Android.mk<br>
@@ -26,10 +26,10 @@ LOCAL_PATH := $(call my-dir)<br>
 include $(CLEAR_VARS)<br>
<br>
 LOCAL_MODULE := gallium_dri<br>
-<br>
+LOCAL_MODULE_CLASS := SHARED_LIBRARIES<br>
 LOCAL_MODULE_RELATIVE_PATH := $(MESA_DRI_MODULE_REL_PATH)<br>
 LOCAL_SRC_FILES := target.c<br>
-<br>
+LOCAL_C_INCLUDES := $(call generated-sources-dir-for,<wbr>STATIC_LIBRARIES,libmesa_util,<wbr>,)<br>
 LOCAL_CFLAGS :=<br>
<br>
 # We need --undefined-version as some functions in dri.sym may be missing<br>
<span class="gmail-HOEnZb"><font color="#888888">--<br>
2.14.1<br>
<br>
</font></span></blockquote></div><br></div></div></div>