<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On 26 Jan. 2018 01:10, "Matthew Nicholls" <<a href="mailto:mnicholls@feralinteractive.com">mnicholls@feralinteractive.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Otherwise cache flushes could get conditionally disabled while still clearing<br>
the flush_bits, and thus flushes due to application pipeline barriers may never<br>
get executed.<br></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">I wonder would we better not predicating flushes. I added that as an extra opt, but it might be the wrong move.</div><div dir="auto"><br></div><div dir="auto">Dave.</div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Cc: <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.<wbr>org</a><br>
---<br>
src/amd/vulkan/radv_meta_fast_<wbr>clear.c | 2 ++<br>
1 file changed, 2 insertions(+)<br>
<br>
diff --git a/src/amd/vulkan/radv_meta_<wbr>fast_clear.c b/src/amd/vulkan/radv_meta_<wbr>fast_clear.c<br>
index fdeeaeedbf..f4353fd889 100644<br>
--- a/src/amd/vulkan/radv_meta_<wbr>fast_clear.c<br>
+++ b/src/amd/vulkan/radv_meta_<wbr>fast_clear.c<br>
@@ -602,6 +602,8 @@ radv_emit_color_decompress(<wbr>struct radv_cmd_buffer *cmd_buffer,<br>
}<br>
<br>
if (!decompress_dcc && image->surface.dcc_size) {<br>
+ si_emit_cache_flush(cmd_<wbr>buffer);<br>
+<br>
radv_emit_set_predication_<wbr>state_from_image(cmd_buffer, image, true);<br>
cmd_buffer->state.predicating = true;<br>
}<br>
<font color="#888888">--<br>
2.13.6<br>
<br>
</font></blockquote></div><br></div></div></div>