<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Feb 24, 2018 5:52 AM, "Timothy Arceri" <<a href="mailto:tarceri@itsqueeze.com">tarceri@itsqueeze.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Using this on its own I believe will cause CTS regressions, which is what the other patches were about. Feel free to take on the feedback and come up with a proper solution. I'm not really sure how to progress this.</blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">The patch is correct. If there are any regression, it's because NIR or GLSL use incorrect transformations.</div><div dir="auto"><br></div><div dir="auto">Marek</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="elided-text"><br>
<br>
<br>
On 24/02/18 00:21, Samuel Pitoiset wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Original patch from Timothy Arceri, I have just fixed the<br>
not equal case locally.<br>
<br>
This fixes one important rendering issue in Wolfenstein 2<br>
(the cutscene transition issue).<br>
<br>
RadeonSI uses the same ordered comparisons, so I guess that<br>
what we should do as well.<br>
<br>
Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=104302" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/s<wbr>how_bug.cgi?id=104302</a><br>
Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=104905" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/s<wbr>how_bug.cgi?id=104905</a><br>
Cc: <<a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop<wbr>.org</a>><br>
Signed-off-by: Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a>><br>
---<br>
src/amd/common/ac_nir_to_llvm.<wbr>c | 6 +++---<br>
1 file changed, 3 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/src/amd/common/ac_nir_to_llv<wbr>m.c b/src/amd/common/ac_nir_to_llv<wbr>m.c<br>
index cccc687157..bc1d16d2a4 100644<br>
--- a/src/amd/common/ac_nir_to_llv<wbr>m.c<br>
+++ b/src/amd/common/ac_nir_to_llv<wbr>m.c<br>
@@ -1801,16 +1801,16 @@ static void visit_alu(struct ac_nir_context *ctx, const nir_alu_instr *instr)<br>
result = emit_int_cmp(&ctx->ac, LLVMIntUGE, src[0], src[1]);<br>
break;<br>
case nir_op_feq:<br>
- result = emit_float_cmp(&ctx->ac, LLVMRealUEQ, src[0], src[1]);<br>
+ result = emit_float_cmp(&ctx->ac, LLVMRealOEQ, src[0], src[1]);<br>
break;<br>
case nir_op_fne:<br>
result = emit_float_cmp(&ctx->ac, LLVMRealUNE, src[0], src[1]);<br>
break;<br>
case nir_op_flt:<br>
- result = emit_float_cmp(&ctx->ac, LLVMRealULT, src[0], src[1]);<br>
+ result = emit_float_cmp(&ctx->ac, LLVMRealOLT, src[0], src[1]);<br>
break;<br>
case nir_op_fge:<br>
- result = emit_float_cmp(&ctx->ac, LLVMRealUGE, src[0], src[1]);<br>
+ result = emit_float_cmp(&ctx->ac, LLVMRealOGE, src[0], src[1]);<br>
break;<br>
case nir_op_fabs:<br>
result = emit_intrin_1f_param(&ctx->ac, "llvm.fabs",<br>
<br>
</blockquote></div><div class="elided-text">
______________________________<wbr>_________________<br>
mesa-stable mailing list<br>
<a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop.<wbr>org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-stable" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-stable</a><br>
</div></blockquote></div><br></div></div></div>