<div dir="ltr"><div>Tested-by: Alex Smith <<a href="mailto:asmith@feralinteractive.com">asmith@feralinteractive.com</a>><br></div><div><br></div><div>Thanks!</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 9 March 2018 at 16:21, Bas Nieuwenhuizen <span dir="ltr"><<a href="mailto:bas@basnieuwenhuizen.nl" target="_blank">bas@basnieuwenhuizen.nl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The vulkan API is not ideal as it does not allow us have a<br>
shared limit.<br>
<br>
Feral needs 15+6 for one of their games, and I'm not a fan<br>
of overcommitting the limits, so increase the number of<br>
dynamic uniform buffers to 16.<br>
<br>
CC: <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.<wbr>freedesktop.org</a>><br>
CC: Alex Smith <<a href="mailto:asmith@feralinteractive.com">asmith@feralinteractive.com</a>><br>
---<br>
src/amd/vulkan/radv_device.c | 4 ++--<br>
src/amd/vulkan/radv_private.h | 4 +++-<br>
2 files changed, 5 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c<br>
index 7a11e08f97..0ed3e27c7b 100644<br>
--- a/src/amd/vulkan/radv_device.c<br>
+++ b/src/amd/vulkan/radv_device.c<br>
@@ -775,9 +775,9 @@ void radv_<wbr>GetPhysicalDeviceProperties(<br>
.maxPerStageResources = max_descriptor_set_size,<br>
.maxDescriptorSetSamplers = max_descriptor_set_size,<br>
.<wbr>maxDescriptorSetUniformBuffers = max_descriptor_set_size,<br>
- .<wbr>maxDescriptorSetUniformBuffers<wbr>Dynamic = MAX_DYNAMIC_BUFFERS / 2,<br>
+ .<wbr>maxDescriptorSetUniformBuffers<wbr>Dynamic = MAX_DYNAMIC_UNIFORM_BUFFERS,<br>
.<wbr>maxDescriptorSetStorageBuffers = max_descriptor_set_size,<br>
- .<wbr>maxDescriptorSetStorageBuffers<wbr>Dynamic = MAX_DYNAMIC_BUFFERS / 2,<br>
+ .<wbr>maxDescriptorSetStorageBuffers<wbr>Dynamic = MAX_DYNAMIC_STORAGE_BUFFERS,<br>
.maxDescriptorSetSampledImages = max_descriptor_set_size,<br>
.maxDescriptorSetStorageImages = max_descriptor_set_size,<br>
.<wbr>maxDescriptorSetInputAttachmen<wbr>ts = max_descriptor_set_size,<br>
diff --git a/src/amd/vulkan/radv_private.<wbr>h b/src/amd/vulkan/radv_private.<wbr>h<br>
index 0f8ddb2e10..439522585a 100644<br>
--- a/src/amd/vulkan/radv_private.<wbr>h<br>
+++ b/src/amd/vulkan/radv_private.<wbr>h<br>
@@ -87,7 +87,9 @@ typedef uint32_t xcb_window_t;<br>
#define MAX_DISCARD_RECTANGLES 4<br>
#define MAX_PUSH_CONSTANTS_SIZE 128<br>
#define MAX_PUSH_DESCRIPTORS 32<br>
-#define MAX_DYNAMIC_BUFFERS 16<br>
+#define MAX_DYNAMIC_UNIFORM_BUFFERS 16<br>
+#define MAX_DYNAMIC_STORAGE_BUFFERS 8<br>
+#define MAX_DYNAMIC_BUFFERS (MAX_DYNAMIC_UNIFORM_BUFFERS + MAX_DYNAMIC_STORAGE_BUFFERS)<br>
#define MAX_SAMPLES_LOG2 4<br>
#define NUM_META_FS_KEYS 13<br>
#define RADV_MAX_DRM_DEVICES 8<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.16.1<br>
<br>
</font></span></blockquote></div><br></div>