<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 13 March 2018 at 19:14, Dave Airlie <span dir="ltr"><<a href="mailto:airlied@gmail.com" target="_blank">airlied@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On 13 March 2018 at 01:38, Alex Smith <<a href="mailto:asmith@feralinteractive.com">asmith@feralinteractive.com</a>> wrote:<br>
> From the spec:<br>
><br>
>     "When copying between compressed and uncompressed formats the<br>
>      extent members represent the texel dimensions of the source<br>
>      image and not the destination."<br>
><br>
> However, as per 7b890a36, we must still use the destination image type<br>
> when clamping the extent so that we copy the correct number of layers<br>
> for 2D to 3D copies.<br>
><br>
> Fixes: 7b890a36 "radv: Fix vkCmdCopyImage for 2d slices into 3d Images"<br>
> Cc: <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.<wbr>freedesktop.org</a>><br>
> Signed-off-by: Alex Smith <<a href="mailto:asmith@feralinteractive.com">asmith@feralinteractive.com</a>><br>
<br>
</span>Reviewed-by: Dave Airlie <<a href="mailto:airlied@redhat.com">airlied@redhat.com</a>><br>
<br>
Might be worth filing a cts issue to see if someone wants to write<br>
tests for this sort of hole.<br></blockquote><div><br></div><div>Thanks, pushed. CTS issue filed: <a href="https://github.com/KhronosGroup/VK-GL-CTS/issues/90">https://github.com/KhronosGroup/VK-GL-CTS/issues/90</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="gmail-HOEnZb"><font color="#888888"><br>
Dave.<br>
</font></span></blockquote></div><br></div></div>