<div dir="ltr"><div>Sounds good to me.<br><br></div>Marek<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 14, 2018 at 6:26 AM, Timothy Arceri <span dir="ltr"><<a href="mailto:tarceri@itsqueeze.com" target="_blank">tarceri@itsqueeze.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
On 14/03/18 19:46, Samuel Pitoiset wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This reverts commit f314a532fdc7af8381586144d2631d<wbr>9968331f05.<br>
<br>
This appears to introduce some blinking textures in UT2004. Not<br>
sure exactly what's the root cause because we don't have much<br>
information about the issue.<br>
<br>
Anyway, this was just a micro optimization that actually breaks,<br>
at least, one app almost one year later.<br>
<br>
Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=105436" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/s<wbr>how_bug.cgi?id=105436</a><br>
Cc: <<a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop<wbr>.org</a>><br>
Signed-off-by: Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a>><br>
---<br>
src/mesa/main/texstate.c | 2 ++<br>
1 file changed, 2 insertions(+)<br>
<br>
diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c<br>
index f9f50a3005..f9b00b4a8f 100644<br>
--- a/src/mesa/main/texstate.c<br>
+++ b/src/mesa/main/texstate.c<br>
@@ -310,6 +310,8 @@ active_texture(GLenum texture, bool no_error)<br>
}<br>
}<br>
<br>
</blockquote>
<br></span>
Can we add a comment here so this doesn't happen again and anyone looking to remove it has a head start on the problem? Maybe something like:<br>
<br>
/* The below flush call seems useless because gl_context::Texture::CurrentUn<wbr>it is not used by<br>
* _mesa_update_texture_state() and friends. However removing<br>
* the flush introduced some blinking textures in UT2004.<br>
* More investigation is needed to find the root cause.<br>
*<br>
* <a href="https://bugs.freedesktop.org/show_bug.cgi?id=105436" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/s<wbr>how_bug.cgi?id=105436</a><br>
*/<br>
<br>
With that:<br>
<br>
Reviewed-by: Timothy Arceri <<a href="mailto:tarceri@itsqueeze.com" target="_blank">tarceri@itsqueeze.com</a>><span class="im HOEnZb"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ FLUSH_VERTICES(ctx, _NEW_TEXTURE_STATE);<br>
+<br>
ctx->Texture.CurrentUnit = texUnit;<br>
if (ctx->Transform.MatrixMode == GL_TEXTURE) {<br>
/* update current stack pointer */<br>
<br>
</blockquote></span><div class="HOEnZb"><div class="h5">
______________________________<wbr>_________________<br>
mesa-stable mailing list<br>
<a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop.<wbr>org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-stable" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-stable</a><br>
</div></div></blockquote></div><br></div>