<div dir="ltr"><div><div>We solve the issue differently but I just verified that it is a problem and also broken in anv and this looks correct to me.<br><br></div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br><br></div>Now you can review my patch. :-P<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 1, 2018 at 9:06 AM, Bas Nieuwenhuizen <span dir="ltr"><<a href="mailto:bas@basnieuwenhuizen.nl" target="_blank">bas@basnieuwenhuizen.nl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Apparently the somewhere between 1.1.70 and 1.1.73 the loader started<br>
depending on this. The loader then creates a 1.0 instance, which gets<br>
into funny situation because we have a 1.1 device.<br>
<br>
No idea how to do line wrapping in Mako though, my random guesses<br>
did not work.<br>
<br>
CC: 18.1 <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.<wbr>freedesktop.org</a>><br>
---<br>
src/amd/vulkan/radv_<wbr>entrypoints_gen.py | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/amd/vulkan/radv_<wbr>entrypoints_gen.py b/src/amd/vulkan/radv_<wbr>entrypoints_gen.py<br>
index 8eb18e64b64..892491e6c30 100644<br>
--- a/src/amd/vulkan/radv_<wbr>entrypoints_gen.py<br>
+++ b/src/amd/vulkan/radv_<wbr>entrypoints_gen.py<br>
@@ -205,7 +205,7 @@ radv_entrypoint_is_enabled(int index, uint32_t core_version,<br>
% if not e.device_command:<br>
if (device) return false;<br>
% endif<br>
- % if <a href="http://e.name" rel="noreferrer" target="_blank">e.name</a> == 'vkCreateInstance' or <a href="http://e.name" rel="noreferrer" target="_blank">e.name</a> == '<wbr>vkEnumerateInstanceExtensionPr<wbr>operties' or <a href="http://e.name" rel="noreferrer" target="_blank">e.name</a> == '<wbr>vkEnumerateInstanceLayerProper<wbr>ties':<br>
+ % if <a href="http://e.name" rel="noreferrer" target="_blank">e.name</a> == 'vkCreateInstance' or <a href="http://e.name" rel="noreferrer" target="_blank">e.name</a> == '<wbr>vkEnumerateInstanceExtensionPr<wbr>operties' or <a href="http://e.name" rel="noreferrer" target="_blank">e.name</a> == '<wbr>vkEnumerateInstanceLayerProper<wbr>ties' or <a href="http://e.name" rel="noreferrer" target="_blank">e.name</a> == 'vkEnumerateInstanceVersion':<br>
return !device;<br>
% elif e.core_version:<br>
return instance && ${e.core_version.c_vk_version(<wbr>)} <= core_version;<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.17.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>