Right, it's a feature we use, because we do all import them as separate EGLImages ... and we won't if it's not advertised.<br><br><div class="gmail_quote"><div dir="ltr">On Wed, 6 Jun 2018, 7:05 pm Jason Ekstrand, <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jun 6, 2018 at 11:03 AM, Jason Ekstrand <span dir="ltr"><<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span>On Wed, Jun 6, 2018 at 11:00 AM, Daniel Stone <span dir="ltr"><<a href="mailto:daniel@fooishbar.org" target="_blank">daniel@fooishbar.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sorry, but as written this will regress ability to import NV12 images as separately-addressed planes with shader conversion to RGB; Kodi, Mutter and Weston all use this.<br></blockquote><div><br></div></span><div>I don't believe it will. It only makes it so that we don't advertise R and RG formats through eglQueryDmaBufFormatsEXT. This means that you can't import the planes each as separate images but you can still import a planar image.</div></div></div></div></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Arguably, though, importing the planes as separate images does sound like a feature...</div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="m_4389716094054925623HOEnZb"><font color="#888888"><div>--Jason</div></font></span><div><div class="m_4389716094054925623h5"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_quote"><div><div class="m_4389716094054925623m_-6229400678578689485h5"><div dir="ltr">On Wed, 6 Jun 2018, 6:48 pm Jason Ekstrand, <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>> wrote:<br></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_4389716094054925623m_-6229400678578689485h5">Cc: <a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop.org</a><br>
---<br>
src/mesa/drivers/dri/i965/intel_screen.c | 12 ++++++++++++<br>
1 file changed, 12 insertions(+)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c<br>
index 5f0eeb41779..f681b221e7b 100644<br>
--- a/src/mesa/drivers/dri/i965/intel_screen.c<br>
+++ b/src/mesa/drivers/dri/i965/intel_screen.c<br>
@@ -1269,6 +1269,18 @@ intel_image_format_is_supported(const struct intel_image_format *fmt)<br>
fmt->fourcc == __DRI_IMAGE_FOURCC_SABGR8888)<br>
return false;<br>
<br>
+ /* The dri_interface.h file says:<br>
+ *<br>
+ * "R8, GR88 and NONE should not be used with createImageFromName or<br>
+ * createImage, and are returned by query from sub images created with<br>
+ * createImageFromNames (NONE, see above) and fromPlane (R8 & GR88)."<br>
+ *<br>
+ * Let's not advertise support for R or RG formats.<br>
+ */<br>
+ if (fmt->components == __DRI_IMAGE_COMPONENTS_R ||<br>
+ fmt->components == __DRI_IMAGE_COMPONENTS_RG)<br>
+ return false;<br>
+<br>
return true;<br>
}<br>
<br>
-- <br>
2.17.1<br>
<br></div></div>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>
</blockquote></div></div></div><br></div></div>
</blockquote></div></div></div></blockquote></div>