Sorry, but as written this will regress ability to import NV12 images as separately-addressed planes with shader conversion to RGB; Kodi, Mutter and Weston all use this. <div class="gmail_quote"><div dir="ltr">On Wed, 6 Jun 2018, 6:48 pm Jason Ekstrand, <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Cc: <a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop.org</a> --- src/mesa/drivers/dri/i965/intel_screen.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 5f0eeb41779..f681b221e7b 100644 --- a/src/mesa/drivers/dri/i965/intel_screen.c +++ b/src/mesa/drivers/dri/i965/intel_screen.c @@ -1269,6 +1269,18 @@ intel_image_format_is_supported(const struct intel_image_format *fmt) fmt->fourcc == __DRI_IMAGE_FOURCC_SABGR8888) return false; + /* The dri_interface.h file says: + * + * "R8, GR88 and NONE should not be used with createImageFromName or + * createImage, and are returned by query from sub images created with + * createImageFromNames (NONE, see above) and fromPlane (R8 & GR88)." + * + * Let's not advertise support for R or RG formats. + */ + if (fmt->components == __DRI_IMAGE_COMPONENTS_R || + fmt->components == __DRI_IMAGE_COMPONENTS_RG) + return false; + return true; } -- 2.17.1 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div>